Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file location utility scripts for current global-workflow monitor data location #142

Merged

Conversation

EdwardSafford-NOAA
Copy link
Collaborator

The file location utilities support 3 data directory structures: operational, global-workflow, and monitor. The global-workflow has changed (a few times) and GSI-Monitor cannot plot directly from the global-workflow monitor directories. This change fixes that. Testing on hera was successful for RadMon, OznMon, and MinMon.

Closes #141.

Update workflow extracted data file location.
Copy link
Collaborator

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but looks OK apart from question about fun.

ush/find_last_cycle.sh Outdated Show resolved Hide resolved
Fix typo in comments.
Copy link
Collaborator

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Conditional approval pending confirmation that changes work as intended.

@EdwardSafford-NOAA
Copy link
Collaborator Author

The images generated from my testing are located on hera at /home/Edward.Safford/nbns/imgn/physics_taper/gdas. These were generated by running these plot scripts using branch feature/updt-wkfl-141 in my GSI-Monitor fork:

  • /scratch1/NCEPDEV/da/Edward.Safford/noscrub/GSI-monitor/src/Radiance_Monitor/image_gen/ush/RadMon_IG_glb.sh physics_taper -p 2023042918 -n 10 -t /scratch1/NCEPDEV/stmp2/Catherine.Thomas/ROTDIRS/
  • /scratch1/NCEPDEV/da/Edward.Safford/noscrub/GSI-monitor/src/Ozone_Monitor/image_gen/ush/OznMon_Plt.sh physics_taper -p 2023042918 -n 10 -t /scratch1/NCEPDEV/stmp2/Catherine.Thomas/ROTDIRS/
    -/scratch1/NCEPDEV/da/Edward.Safford/noscrub/GSI-monitor/src/Minimization_Monitor/image_gen/ush /MinMon_Plt.sh physics_taper -p 2023042918 -t /scratch1/NCEPDEV/stmp2/Catherine.Thomas/ROTDIRS/

Log files are located on hera at /scratch2/NCEPDEV/stmp3/Edward.Safford/logs/physics_taper/gdas. There are warnings of missing files because the data only covers a few cycles, but I did not see any errors.

@RussTreadon-NOAA
Copy link
Collaborator

If you good with what you see @EdwardSafford-NOAA , I'll merge this PR into develop. Just let me know.

@EdwardSafford-NOAA
Copy link
Collaborator Author

@RussTreadon-NOAA I am indeed. Plotting directly from Cathy's workflow output directory is working as intended. Thanks!

@RussTreadon-NOAA RussTreadon-NOAA merged commit 4e5feb7 into NOAA-EMC:develop Aug 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the output location for workflow data
2 participants